[vlc-devel] [PATCH] DVB-S scanning support

[Ilkka Ollakka]

On Mon, Aug 02, 2010 at 01:21:40PM +0300, David Kaplan wrote:
> DVB satellite scanning using transponder lists from the config directory

Does those satelites really change that often that they need
config-file, or is there so many of those?

>  /* Satellite */
> +#define SATELLITE_TEXT N_("Satellite scanning config")
> +#define SATELLITE_LONGTEXT N_("filename of config file in share/dvb/dvb-s")

Does this mean it only needs filename, or full path with filename?

> -#define DVB_SCAN_MAX_SIGNAL_TIME (300*1000)
> +#define DVB_SCAN_MAX_SIGNAL_TIME (1000*1000)
>  #define DVB_SCAN_MAX_LOCK_TIME (5000*1000)
> -#define DVB_SCAN_MAX_PROBE_TIME (30000*1000)
> +#define DVB_SCAN_MAX_PROBE_TIME (45000*1000)

Doesn't this slowdown all the other scannings ?


> -static int ScanDvbTNextExhaustive( scan_t *p_scan, scan_configuration_t *p_cfg, double *pf_pos )
> +static int ScanDvbNextExhaustive( scan_t *p_scan, scan_configuration_t *p_cfg, double *pf_pos )

I think it would be clearer to make separated patch that does
non dvb-s scanning related changes.

-- 
Ilkka Ollakka
Stay away from flying saucers today.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20100802/086432cd/attachment.sig>