[vlc-devel] [PATCH] DVB-S scanning support

[David Kaplan]

On Mon, Aug 2, 2010 at 2:13 PM, Ilkka Ollakka <ileoo at videolan.org> wrote:

> On Mon, Aug 02, 2010 at 01:21:40PM +0300, David Kaplan wrote:
> > DVB satellite scanning using transponder lists from the config directory
>
> Does those satelites really change that often that they need
> config-file, or is there so many of those?
>

There are a LOT of them.


> >  /* Satellite */
> > +#define SATELLITE_TEXT N_("Satellite scanning config")
> > +#define SATELLITE_LONGTEXT N_("filename of config file in
> share/dvb/dvb-s")
>
> Does this mean it only needs filename, or full path with filename?
>

Only filename - will make it clearer


>
> > -#define DVB_SCAN_MAX_SIGNAL_TIME (300*1000)
> > +#define DVB_SCAN_MAX_SIGNAL_TIME (1000*1000)
> >  #define DVB_SCAN_MAX_LOCK_TIME (5000*1000)
> > -#define DVB_SCAN_MAX_PROBE_TIME (30000*1000)
> > +#define DVB_SCAN_MAX_PROBE_TIME (45000*1000)
>
> Doesn't this slowdown all the other scannings ?
>

Yes it does but I'm not sure that's a bad thing. My tests showed a LOT of
unnecessary timeouts with lower signal times.
I think that this is a good compromise.

Also as part of my ongoing dvb improvements, I hope to make persisting of
the canned lists more logical so scanning isn't performed very often.


> > -static int ScanDvbTNextExhaustive( scan_t *p_scan, scan_configuration_t
> *p_cfg, double *pf_pos )
> > +static int ScanDvbNextExhaustive( scan_t *p_scan, scan_configuration_t
> *p_cfg, double *pf_pos )
>
> I think it would be clearer to make separated patch that does
> non dvb-s scanning related changes.
>

I can do this - problem is that I've done it all together already and now
I'd have to manually go and find each place and split it up.
The changes were really minor so is this strictly necessary?

-- 
http://blog.2of1.org
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20100802/0515b7bc/attachment.html>