[vlc-devel] [PATCH] Direct3D shader support (HLSL)

[xxcv]

On 14/08/2010 4:24 PM, Sasha Koruga wrote:
> Hi,
> Is there a recommended way to benchmark VLC? Does VLC already have
> built-in functionality that says how long it takes to render a frame?
I'm not sure about that... if there's a module or core features showing 
FPS live on the screen.
On the other hand, I have just compiled your patch which I merged into 
my personal build of the vlc-1.1 series and I have found that it a very 
very nice feature to have and have nice effects available at the user's 
convenience.
Some problems when I test:
1.
However, initially it won't compile because:
D3DXFX_NOT_CLONEABLE is not defined in anywhere inside the mingw-w64 
headers.
I can see the exact value in 
http://goodrender.googlecode.com/svn-history/r2/trunk/include/d3dx9effect.h
and have substituted it in directly.
And the value should have been inside the d3dx9effect.h
http://msdn.microsoft.com/en-us/library/bb172855%28v=VS.85%29.aspx

2.
It crashed when I first played back a mpeg2 video, this happened at 
loading video.
At function CommonUpdatePicture
On this line, dst->p_pixels = src->p_pixels;

3.
I loaded another xvid video it crashed on exit for some reason.

In conclusion, I like your patch very much, it shows me some very neat 
and nice video effects and features.
IMO, as a user, I like the descriptions of the effects showing on menu a 
more easier to understand and self explanatory if possible.
>
> Regards,
> Sasha

Thanks again for a very nice feature add-on to the d3d vout module :)


Best Regards,

-- 
My VLC, My Way, My Style~