[vlc-devel] [vlc-commits] commit: Add a test about chain escaping escaping. ( Rémi Duraffort )

[Rémi Denis-Courmont]

On Tue, 31 Aug 2010 22:22:35 +0200 (CEST), git at videolan.org wrote:
> vlc | branch: master | Rémi Duraffort <ivoire at videolan.org> | Tue Aug 31
> 21:51:02 2010 +0200| [2d268697cdb889a102c580e12e1e1fdfd8f9db6b] |
> committer: Rémi Duraffort 
> 
> Add a test about chain escaping escaping.
> 
>>
>
http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=2d268697cdb889a102c580e12e1e1fdfd8f9db6b
> ---
> 
>  test/Makefile.am        |    6 +++
>  test/src/config/chain.c |   79
> +++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 85 insertions(+), 0 deletions(-)

IMHO, libvlccore tests belong in src/test ...
Conversely, I think we should move libvlc from src/control/ to something/
but I cannot figure out what, lib/ maybe.

> +int main( void )
> +{
> +    log( "Testing config chain escaping\n" );
> +    test_config_StringEscape();
> +    log( "Testing config chain un-escaping\n" );
> +    test_config_StringUnEscape();
> +}

Missing return statement! Does the compiler not warn about this?? I also
don't see NDEBUG being undefined anywhere, to make sure assert() is
evaluated, but maybe the .h file takes care of that.

-- 
Rémi Denis-Courmont
http://www.remlab.net
http://fi.linkedin.com/in/remidenis