[vlc-devel] [PATCH] Qt/ML: New Models for Playlist UI

[Jean-Baptiste Kempf]

On Wed, Dec 29, 2010 at 07:53:44PM +0530, Srikanth Raju wrote :
> On Tue, Dec 28, 2010 at 5:20 AM, Jean-Baptiste Kempf <jb at videolan.org> wrote:
> > As much as I don't like the one-big-patch way especially because a
> > first patch to move the PLModel to VLCModel+PLModel was necessary, I
> > won't nitpick too much now.
> >
> 
> Broken down patches further
Cool.

> Subject: [PATCH 1/3] Qt/ML: VLC Model

Seems ok

> Subject: [PATCH 2/3] Qt/ML: ML Model and Item

> +        case ML_TYPE:
What is ML_TYPE used for?

> +                if( p_person->psz_name && *p_person->psz_name )
!EMPTY_STR( p_person->psz_name ) maybe?

> +        case ML_TITLE:
> +        {
> +            /* If no title, return filename */
> +            if( media->psz_title && *media->psz_title )
> +                return qfu( media->psz_title );
I believe this should be merged with other functions that do mostly the
same, in the future.

> +#include <vlc/vlc.h>
Why?

> +bool MLModel::popup( const QModelIndex & index, const QPoint &point, const QModelIndexList &list )
Why is that not in VLCModel?

And a few other linked to popup too?

> +/*****************************************************************************
> + * mlresultlist.hpp: the media library's columns
Wrong filename :)

> +#include <vlc/vlc.h>
Same question

> Subject: [PATCH 3/3] Qt/ML: Extend Playlist model from VLCModel
Seems ok

Best Regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/
+33 672 704 734