[vlc-devel] commit: Qt4 Icon View: cache full rendering for each item ( Rafaël Carré )

[Jakob Leben]

On Thu, Jan 28, 2010 at 6:26 PM, git version control <git at videolan.org>wrote:

> vlc | branch: master | Rafaël Carré <rafael.carre at gmail.com> | Thu Jan 28
> 18:25:57 2010 +0100| [4e68ddd0e7ac2f5d8b1346effe9a4359fc1e5c75] | committer:
> Rafaël Carré
>
> Qt4 Icon View: cache full rendering for each item
>
>
I believe this actually performs much poorer in case the found art picture
is huge and needs to be scaled down a lot. The scaling and rendering of art
is the most expensive part, and still it is performed for every single item,
even if they share the same art, because a different pixmap is created and
cached per item.

I would go back to caching only art. Text rendering is not that expensive.
Or if you definitely want to cache the text, then it should be cached
separately from art.

Best regards,

Jakob
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20100210/60662594/attachment.html>