[vlc-devel] commit: vlm: Remove the callback before joining the thread, and save a dead lock. (Pierre d'Herbemont )

[Pierre d'Herbemont]

On Fri, Feb 12, 2010 at 8:22 AM, Sébastien Escudier
<sebastien-devel at celeos.eu> wrote:
> Quoting Pierre d'Herbemont <pdherbemont at free.fr>:
>
>> Which one would you expect? The correct fix is trivial if you want the
>> Stop event.
>
> Yes, I was thinking to the stop event, but we might loose some others.
> Moreover it doesn't seem clean.
> The logic is :
> - add callback
> - start input
> [...]
> - stop input
> - del callback

Speaking of clean, the signaling stuff is completly unclean. The
callback is being used for two things. Signaling and transmitting the
input event. I guess what you want is two callbacks one for signalling
the other one for transmitting. The signaling callback *needs* to be
removed before stoping the input.

Pierre.