[vlc-devel] [PATCH 3/3] Qt: Call Lua status callbacks onplaying	status changes
    Jean-Philippe André 
    jpeg at videolan.org
       
    Sun Feb 14 17:34:17 CET 2010
    
    
  
Sunday 14 February 2010, 04:32:34,
Srikanth Raju wrote:
> Updated patch to work with changes in the last patch
These patches look good to me.
Maybe rename "playing-listener" into "status-listener" as the hook is called 
"status_changed".
Other remark: I think you leak the integer argument for CMD_PLAYING_CHANGED. 
See FreeCommands.
Best,
-- 
Jean-Philippe André (jpeg)
    
    
More information about the vlc-devel
mailing list