[vlc-devel] [PATCH 3/3] Qt: Call Lua status callbacks onplaying status changes

[Srikanth Raju]

Hello,

On Sun, Feb 14, 2010 at 10:04 PM, Jean-Philippe André <jpeg at videolan.org> wrote:
> Sunday 14 February 2010, 04:32:34,
> Srikanth Raju wrote:
>> Updated patch to work with changes in the last patch
>
> These patches look good to me.
>
> Maybe rename "playing-listener" into "status-listener" as the hook is called
> "status_changed".

The hook is now called playing_changed. I changed it last patch.

>
> Other remark: I think you leak the integer argument for CMD_PLAYING_CHANGED.
> See FreeCommands.
>

Correct. Fixed. Updated patch is in the 0002 thread.

> Best,
>
> --
> Jean-Philippe André (jpeg)
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel
>



-- 
Regards,
Srikanth Raju