[vlc-devel] [PATCH] Enable Lua SD loading with -S<name>

[Rémi Denis-Courmont]

Le mardi 16 février 2010 21:51:41 Jean-Philippe André, vous avez écrit :
> Hi,
> 
> With this series of patches, it is possible to load any LuaSD using
>  -S<name> This way we don't need to hard-code freebox and frenchtv.
> 
> As this is a bit overkill (compared to the previous hacks) and I'm not
>  totally sure about it, I prefer asking for a review.

I really think that non-strict probing makes no sense, since we have no 
generic input to probe here. You necessarily what you are loading. Hence this 
is a horrible hack. Also removing strict makes things slow, as more plugins 
need to be loaded, probed and unloaded. And in the mean time, the UI will 
freeze! This is especially bad considering how easy writing new SD plugins has 
become.

By the way, using fopen() on a LUA file only works in the build tree. 
Otherwise, the files are byte compiled. In other words, it does not work.

I will merge patch 4. I don't understand what the fifth does.

-- 
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis