[vlc-devel] [PATCH] Enable Lua SD loading with -S<name>

[Jean-Philippe André]

Tuesday 16 February 2010, 21:08:19,
Rémi Denis-Courmont wrote:
> Le mardi 16 février 2010 21:51:41 Jean-Philippe André, vous avez écrit :
> > Hi,
> >
> > With this series of patches, it is possible to load any LuaSD using
> >  -S<name> This way we don't need to hard-code freebox and frenchtv.
> >
> > As this is a bit overkill (compared to the previous hacks) and I'm not
> >  totally sure about it, I prefer asking for a review.
> 
> I really think that non-strict probing makes no sense, since we have no
> generic input to probe here. You necessarily what you are loading. Hence
>  this is a horrible hack. Also removing strict makes things slow, as more
>  plugins need to be loaded, probed and unloaded. And in the mean time, the
>  UI will freeze! This is especially bad considering how easy writing new SD
>  plugins has become.

Yes, that's what I was afraid of, exactly...
Maybe we would need to have a special "services-discovery" module type that 
would be able to match any SD (like Lua does).
But not in a feature freeze :-)

> By the way, using fopen() on a LUA file only works in the build tree.
> Otherwise, the files are byte compiled. In other words, it does not work.

Oops, forgot that!

> I will merge patch 4. I don't understand what the fifth does.

Patch 5 is related to what patch 1 does with p_sd->psz_name: it is used to set 
an appropriate long name for the SD playlist root node.
Actually, this also fixes the names of SDs in the rc interface when loaded by -
S<name> (marked as '?').

Thanks for the quick review.

-- 
Jean-Philippe André (jpeg)