[vlc-devel] commit: Mostly revert "libvlc: add mouse events as libvlc_MediaPlayerEvents " ( Rémi Denis-Courmont )

[Jean-Paul Saman]

On Thu, Feb 18, 2010 at 8:58 AM, Rémi Denis-Courmont <remi at remlab.net> wrote:
> ----- Message d'origine -----
>> On Wed, Feb 17, 2010 at 11:07 PM, git version control <git at videolan.org> wrote:
>> You could have
>> suggested another way of implementing this during the review of this
>> code.
>
> You seem to assume that I (a hobbyist) have a duty to review and provide solutions. I do not. If something does not work it is the author's duty to reimplement it in a correct way. Not the reviewer.

You seem to have the impression that I asked you for an
implementation. That was not my intention.

>> Only reverting is not helpful IMHO.
>
> Making LibVLC not dead lock is helpful. Not publishing a bad API that we would need to support I do not know how long is helpfull too.
>

Where does the deadlock occur? so that I can fix it,
How can I trigger the deadlock ?

If the implementation of remembering the vout in the media_player is
the wrong approach, then what would be an alternative?
Using var_InHerit() ? Registering "mouse-move",  "mouse-click" and
"mouse-button-down" on the media player object and Inherit it in vout
?


gtz
Jean-Paul Saman