[vlc-devel] commit: Mostly revert "libvlc: add mouse events as libvlc_MediaPlayerEvents " ( Rémi Denis-Courmont )

[Rémi Denis-Courmont]

----- Message d'origine -----
> On Wed, Feb 17, 2010 at 11:07 PM, git version control <git at videolan.org> wrote:
> > vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Wed Feb 17
> > 23:23:50 2010 +0200| [e51d033c69bcfcb70b2317b040bc90fa3a8eda56] | committer:
> > Rémi Denis-Courmont
> >
> > Mostly revert "libvlc: add mouse events as libvlc_MediaPlayerEvents"
> >
> > This mostly reverts commit 114b922fa7bbe06f4acfcc3d7af9c47ef534b1a2.
> > This introduces deadlocks in the LibVLC media player event handling.
>
> Why did you revert this code without talking to me?

You quoted the answer to the question.

> You could have
> suggested another way of implementing this during the review of this
> code.

You seem to assume that I (a hobbyist) have a duty to review and provide solutions. I do not. If something does not work it is the author's duty to reimplement it in a correct way. Not the reviewer.

We hobbyists are doing the project a big favor by reviewing patches and commits already. I do not owe you anything. 

> Only reverting is not helpful IMHO.

Making LibVLC not dead lock is helpful. Not publishing a bad API that we would need to support I do not know how long is helpfull too.

And by the way, nobody contended my multiple comments that this was useless. So it was only logical to assume that it could be removed.

Not to mention that this was not covered in the testsuite, yet was committed really late in the release process. That is a very bad combination for race prone (events handling) stuff.
-- 
Rémi