[vlc-devel] commit: Lua SD: let the user know we are working (Fabio Ritrovato )

[Jakob Leben]

On Wed, Feb 24, 2010 at 2:06 PM, Fabio Ritrovato <exsephiroth87 at gmail.com>wrote:

> On Wed, Feb 24, 2010 at 1:54 PM, Pierre d'Herbemont <pdherbemont at free.fr>
> wrote:
> >
> > On Wed, Feb 24, 2010 at 10:00 AM, Jakob Leben <jakob.leben at gmail.com>
> wrote:
> >> Hi Fabio, here is my opinions on the patch:
> >>
> >> I believe the services_discovery_t: b_loading field should be protected
> by
> >> some mutex, which services_discovery_t does not have yet.
> >>
> >> I would suggest to:
> >>
> >> A. Either move the b_loading field into playlist's struct
> >> vlc_sd_internal_t and use playlist lock to protect it, while adding a
> public
> >> function playlist_IsServicesDiscoveryLoading( ).
> >
> > Was going to suggest the same thing. Except, put it in the (just added)
> > services_discovery's private member. And use
> services_discovery_IsLoading().
> >>
> >> B: Or remove the b_loading field and pass the loading state as bool
> >> through callbacks all the way until Qt intf.
> >
> > As you want :)
>
> I had the feeling something was missing...
>
> Passing just the state I feel won't give enough informations to the
> interface, so I think I'll keep passing the p_sd...
>


I agree, I'd prefer storing the state somewhere. I am only undecided as to
storing it in vlc_sd_internal_t and using playlist lock, or adding a lock to
services_discovery_t. I am inclining towards the latter, as it can be
necessary in future anyway.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20100224/b10866e5/attachment.html>