[vlc-devel] [PATCH] Add option to disable DVD subtitle transparency
Rémi Denis-Courmont
remi at remlab.net
Sun Jan 17 15:35:18 CET 2010
Le dimanche 17 janvier 2010 16:22:11 Kaarlo Räihä, vous avez écrit :
> > + change_need_restart ()
> >
> > Why does this need a restart??
>
> I am living under assumption that if there isn't a callback to care about
> runtime changes, restart is needed. If this assumption is wrong, I can
> change the code.
A restart is needed if the value is read only when the VLC core "boots". The
stereotypical example is localization. For most setting, a stop/play cycle
will apply the new setting.
> > Why do you create a new object variable? This seems totally
> > contradictory
> > with
> > requiring a restart.
>
> I should use var_Create( p_dec, "dvdsub-transparency", VLC_VAR_BOOL |
> VLC_VAR_DOINHERIT ); instead or ?
If nobody registers a callbacks or otherwise uses the variable on that
particular object, you can simply do:
p_sys->b_disabletrans = var_InheritBool( p_dec, "dvbsub-transparency" );
--
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis
More information about the vlc-devel
mailing list