[vlc-devel] [PATCH] Add option to disable DVD subtitle transparency

[Kaarlo Räihä]

I removed restart, changed to var_InheritBool and also made ints to bools. But for some reason var_InheritBool returns always true.

Rémi Denis-Courmont kirjoitti 17.01.2010 kello 16:35:
> Le dimanche 17 janvier 2010 16:22:11 Kaarlo Räihä, vous avez écrit :
> > > +    change_need_restart ()
> > >
> > > Why does this need a restart??
> > 
> > I am living under assumption that if there isn't a callback to care about
> >  runtime changes, restart is needed. If this assumption is wrong, I can
> >  change the code.
> 
> A restart is needed if the value is read only when the VLC core "boots".
> The 
> stereotypical example is localization. For most setting, a stop/play
>  cycle 
> will apply the new setting.
> 
> > > Why do you create a new object variable? This seems totally
> > >  contradictory
> > > with
> > > requiring a restart.
> > 
> > I should use var_Create( p_dec, "dvdsub-transparency", VLC_VAR_BOOL |
> >  VLC_VAR_DOINHERIT ); instead or ?
> 
> If nobody registers a callbacks or otherwise uses the variable on that 
> particular object, you can simply do:
> 
> p_sys->b_disabletrans = var_InheritBool( p_dec, "dvbsub-transparency" );
> 
> -- 
> Rémi Denis-Courmont
> http://www.remlab.net/
> http://fi.linkedin.com/in/remidenis
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel


....................................................................
Luukku Plus -paketilla pääset eroon tila- ja turvallisuusongelmista.
Hanki Luukku Plus ja helpotat elämääsi. http://www.mtv3.fi/luukku
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-dvd-subtitle-transparency-fixes-Yac.patch
Type: application/octet-stream
Size: 1685 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20100123/68539aad/attachment.obj>