[vlc-devel] [PATCH] i18n: Manage i18n in integer and string lists

gozer at progrock.com gozer at progrock.com
Mon Jan 18 18:16:26 CET 2010


I don't see the link with the "plugins cache" ?

If you don't call the _() function on the text descriptions it's not translated in the GUI.
The text[i) table below is the text "attached" to each option in the modules (and each option has also an int value used by the code) and this should not corrupt anything.

Please correct me if I'm wrong!

--
    Eric Lassauge 
        <gozer {at} progrock [dot] com>
        #lassauge [at] users {dot} sf {dot} net#

--- remi at remlab.net wrote:

From: Rémi Denis-Courmont <remi at remlab.net>
To: Mailing list for VLC media player developers <vlc-devel at videolan.org>
Subject: Re: [vlc-devel] [PATCH] i18n: Manage i18n in integer and string	lists
Date: Fri, 15 Jan 2010 12:14:05 +0100


The plugins cache is independent from the locale. I think this change would
corrupt it.

On Fri, 15 Jan 2010 02:38:41 -0800, "Dupont Lajoie" <gozer at progrock.com>
wrote:
> 
> ---
>  src/modules/entry.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/src/modules/entry.c b/src/modules/entry.c
> index 1b5dba6..e264b41 100644
> --- a/src/modules/entry.c
> +++ b/src/modules/entry.c
> @@ -386,7 +386,7 @@ int vlc_plugin_set (module_t *module, module_config_t
> *item, int propid, ...)
>                  if( dtext != NULL )
>                  {
>                      for (size_t i = 0; i < len; i++)
> -                        dtext[i] = text[i] ? strdup (text[i]) : NULL;
> +                        dtext[i] = text[i] ? strdup (_(text[i])) : NULL;
>                      dtext[len] = NULL;
>                  }
>                  item->ppsz_list_text = dtext;
> --
> 1.6.1.2
> 
> 
> --
>     Eric Lassauge
>         <gozer {at} progrock [dot] com>
>         #lassauge [at] users {dot} sf {dot} net#
> 
> _____________________________________________________________
> For the best in Progressive Rock on the internet, check out PROGROCK.COM!
> http://www.progrock.com
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel
-- 
Rémi Denis-Courmont
http://www.remlab.net
http://fi.linkedin.com/in/remidenis

_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
http://mailman.videolan.org/listinfo/vlc-devel




_____________________________________________________________
For the best in Progressive Rock on the internet, check out PROGROCK.COM!
http://www.progrock.com


More information about the vlc-devel mailing list