[vlc-devel] [PATCH] Fix-for-TS-Muxer-memory-leak (Part II)

[Robert Krakora]

On Sun, Jan 24, 2010 at 10:46 AM, Rafaël Carré <rafael.carre at gmail.com>wrote:

> On Sat, 23 Jan 2010 21:51:40 -0500
> Robert Krakora <rob.krakora at messagenetsystems.com> wrote:
>
> > The patch looks good.  I have had it running on over 100 Linux-based
> > mediaports since I came up with it in September and have seen no
> > reoccurance of the memory leak.
>
> I can't review the patch but here some remarks made on irc:
>
> 19:37 < nefrir> mmh the code style is wrong (ie not consistant)
> 19:37 < funman> also the for (i=-1...) looks weird
> 19:39 < nefrir> and the patch protects only against audio missing I
> think
> 19:39 < nefrir> (his use case)
> 19:40 < j-b> beurk at the patch then
>
> JPsaman could you have a look at it ?
>
>
> --
> Rafaël Carré
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel
>
> Hello,

Yes, the memory leak bug came into play originally when audio was missing
and that is what was patched.  It should also work if video is missing.  The
rest of the services need to be patched as well.  However, it seemed to me
that audio and video services were the only services referenced by the
file.  Yes, I did create the patch to cover my use case as it makes use of
only video and audio services.  I would encourage someone with more VLC
knowledge than myself to revise/rewrite the patch or re-architect the module
correctly.  I appreciate Rafaël for bringing attention to this issue as I
would like this bug to be fixed correctly.  ;-)

Best Regards,

-- 
Rob Krakora
Senior Software Engineer
MessageNet Systems
101 East Carmel Dr. Suite 105
Carmel, IN 46032
(317)566-1677 Ext. 206
(317)663-0808 Fax
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20100124/36285ad1/attachment.html>