[vlc-devel] commit: Do not export unimplemented functions ( Rémi Denis-Courmont )

[Jean-Paul Saman]

On Mon, Jan 25, 2010 at 1:46 PM, Rafaël Carré <rafael.carre at gmail.com> wrote:
> On Mon, 25 Jan 2010 09:45:31 +0100
> Jean-Paul Saman <jpsaman at gmail.com> wrote:
>
>> On Sun, Jan 24, 2010 at 10:53 PM, Jean-Baptiste Kempf
>> <jb at videolan.org> wrote:
>> > On Sun, Jan 24, 2010 at 10:56:54AM +0100, git version control
>> > wrote :
>> >> Do not export unimplemented functions

To set and get teletext pages in the browser plugins a pointer to the
zvbi module is needed. The zvbi module exports an variable 'vbi-page'
which needs to be queried to get the current teletext page. Or setted
to change the teletext page. In src/control/video.c the marquee and
the logo video filters have the same problem and there it is solved in
the following way.

static vlc_object_t *get_marquee_object( libvlc_media_player_t * p_mi )
{
    libvlc_exception_t e;
    libvlc_exception_init(&e);
    vout_thread_t * vout = GetVout( p_mi, &e );
    libvlc_exception_clear(&e);
    if( !vout )
        return NULL;
    vlc_object_t * object = vlc_object_find_name( vout, "marq", FIND_CHILD );
    vlc_object_release(vout);
    return object;
}

For the teletext (zvbi) this would look like this:

static vlc_object_t *get_zvbi_object( libvlc_media_player_t * p_mi )
{
    libvlc_exception_t e;
    libvlc_exception_init(&e);
    vout_thread_t * vout = GetVout( p_mi, &e );
    libvlc_exception_clear(&e);
    if( !vout )
        return NULL;
    vlc_object_t * object = vlc_object_find_name( vout, "zvbi", FIND_CHILD );
    vlc_object_release(vout);
    return object;
}

There is one other way to solve this by moving the variable 'vbi-page'
in to vlc core. What is the recommended way?

Kind regards,
Jean-Paul Saman