[vlc-devel] commit: Do not export unimplemented functions ( Rémi Denis-Courmont )
remi at remlab.net
Wed Jan 27 11:44:33 CET 2010
On Tue, 26 Jan 2010 11:23:01 +0100, Jean-Paul Saman <jpsaman at gmail.com>
> static vlc_object_t *get_marquee_object( libvlc_media_player_t * p_mi )
> libvlc_exception_t e;
> vout_thread_t * vout = GetVout( p_mi, &e );
> if( !vout )
> return NULL;
> vlc_object_t * object = vlc_object_find_name( vout, "marq",
> return object;
That code is buggy as hell, so I wouldn't take it as a reference. It fails
if there is more than one marquee, which is possible even with a single
video output. It also fails if the marquee filter is not yet fully
initialized - with no sane way to wait for it to be ready.
> There is one other way to solve this by moving the variable 'vbi-page'
> in to vlc core. What is the recommended way?
That's even worse. It would fail to account for multiple inputs.
More information about the vlc-devel