[vlc-devel] commit: Refactor libvlc_video_{get, set}_{marquee, logo}_{int, string}. ( JP Dinger )

[Pierre d'Herbemont]

This is a r- for me.

You're not doing something wise API-wise IMO.

Your return value is error prone, and need documentation. Previous
implementation was just fine to get/check, when reading code or by
simple compilation. The way it is done add a new range of error and
mistake done by user.

What's your rational? I would say revert.

Pierre.

On Fri, Jan 29, 2010 at 4:55 PM, git version control <git at videolan.org> wrote:
> vlc | branch: master | JP Dinger <jpd at videolan.org> | Tue Jan 26 16:06:14 2010 +0100| [da87f0fe504c5c4126b6bed5f7c660ddf42d4a54] | committer: JP Dinger
>
> Refactor libvlc_video_{get,set}_{marquee,logo}_{int,string}.
>
>> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=da87f0fe504c5c4126b6bed5f7c660ddf42d4a54
> ---
>
>  include/vlc/libvlc_media_player.h |   25 +--
>  src/control/video.c               |  395 ++++++++++++++++---------------------
>  2 files changed, 182 insertions(+), 238 deletions(-)
>
> Diff:   http://git.videolan.org/gitweb.cgi/vlc.git/?a=commitdiff;h=da87f0fe504c5c4126b6bed5f7c660ddf42d4a54
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel
>