[vlc-devel] commit: Refactor libvlc_video_{get, set}_{marquee, logo}_{int, string}. ( JP Dinger )

Pierre d'Herbemont pdherbemont at free.fr
Fri Jan 29 22:16:55 CET 2010

On Fri, Jan 29, 2010 at 10:12 PM, Pierre d'Herbemont
<pdherbemont at free.fr> wrote:
> This is a r- for me.
> You're not doing something wise API-wise IMO.
> Your return value is error prone, and need documentation. Previous
> implementation was just fine to get/check, when reading code or by
> simple compilation. The way it is done add a new range of error and
> mistake done by user.
> What's your rational? I would say revert.

I would like this kind of API *change* to be raised on vlc-devel, to
ensure a better review. And it would probably not create useless work.


More information about the vlc-devel mailing list