[vlc-devel] [PATCH] support for stream size in imem access?module

Rémi Denis-Courmont remi at remlab.net
Thu Jul 1 11:54:37 CEST 2010

On Thu, 1 Jul 2010 10:28:03 +0200, Laurent Aimar <fenrir at elivagar.org>
> On Thu, Jul 01, 2010 at 09:57:31AM +0200, Rémi Denis-Courmont wrote:
>> On Thu, 1 Jul 2010 00:28:38 +0200, Laurent Aimar <fenrir at elivagar.org>
>> wrote:
>> >  Your patch in itself is fine, but I wonder if we shouldn't add
> (u)int64
>> > config support first. var_* does support int64_t using var_*Time, the
>> only
>> > bit missing seems to be config_* part.
>> > 
>> >  Anyone against config_ int64_t type support ? (If none, I will try to
>> add
>> > it).
>> IMHO we should merge int and int64 since configuration and variable
> values
>> are stored in a union anyway. And yes, I imply that var_*Time() should
> be
>> gotten rid of.
>  Unless I misunderstood, a union of int and int64 won't behave nicely on
> big endian CPU ie reading using the int doesn't give you the same value
> as reading using the int64 even when the value can be stored without loss
> by both.

Oh yeah. I just meant that since the union contains a 64-bits integer, we
might as well store all integer values as 64-bits. That seems simpler and
cleaner than marking all 64-bits values as "time". Casting will take care
of the rest transparently.

Rémi Denis-Courmont

More information about the vlc-devel mailing list