[vlc-devel] [PATCH] support for stream size in imem?access?module

Laurent Aimar fenrir at elivagar.org
Thu Jul 1 20:18:37 CEST 2010


On Thu, Jul 01, 2010 at 11:54:37AM +0200, Rémi Denis-Courmont wrote:
> Oh yeah. I just meant that since the union contains a 64-bits integer, we
> might as well store all integer values as 64-bits. That seems simpler and
> cleaner than marking all 64-bits values as "time". Casting will take care
> of the rest transparently.
 You mean to:
 - remove vlc_value_t::i_time
 - change vlc_value_t::i_int type to int64_t
 - change var_*Integer to use/return int64_t type
 - remove var_*Time
 ?

 If so, it is doable, but we will have a lot of code to review (especially
all printf like functions using var_Get/InheritInteger or vlc_value_t::i_int
as argument).

-- 
fenrir



More information about the vlc-devel mailing list