[vlc-devel] [PATCH] MKV : Always export CodecPrivate (as the ES' extradata) if it is present.

Rafaël Carré rafael.carre at gmail.com
Thu Jul 1 18:26:11 CEST 2010

On Thu,  1 Jul 2010 20:43:43 +0530
Jai Menon <jmenon86 at gmail.com> wrote:

> +        // Export CodecPrivate if it is present and the ES format's
> +        // extradata field hasn't been populated yet.

Where else could have it been populated ?

> +        if( !p_tk->fmt.p_extra && p_tk->i_extra_data )
> +            fill_extra_data( p_tk );

I didn't read the ~6k lines of C++ but from a quick look, there is no
reason why the extradata is stored in ->(i/p)_extra_data instead of
storing it directly in ->fmt.(i/p)_extra

Rafaël Carré

More information about the vlc-devel mailing list