[vlc-devel] [PATCH] MKV : Always export CodecPrivate (as the ES' extradata) if it is present.

[Jai Menon]

On Thu, Jul 1, 2010 at 9:56 PM, Rafaël Carré <rafael.carre at gmail.com> wrote:
> On Thu,  1 Jul 2010 20:43:43 +0530
> Jai Menon <jmenon86 at gmail.com> wrote:
>
>> +        // Export CodecPrivate if it is present and the ES format's
>> +        // extradata field hasn't been populated yet.
>
> Where else could have it been populated ?

This is just the fallback case, so to say. If any specific
parsing/manipulation on a per-codec basis needs to be done, then the
if-else constructs just above should handle those. Or did I
misunderstand your question?

>> +        if( !p_tk->fmt.p_extra && p_tk->i_extra_data )
>> +            fill_extra_data( p_tk );
>
> I didn't read the ~6k lines of C++ but from a quick look, there is no
> reason why the extradata is stored in ->(i/p)_extra_data instead of
> storing it directly in ->fmt.(i/p)_extra

Of course, that could be done too. As a separate patch perhaps?
Also, there's quite a lot of stuff to clean up in there :)

-- 
Jai Menon