[vlc-devel] [PATCH] Another attempt to add vout_window_t support to macosx video output
juhovh at iki.fi
Thu Jul 22 14:33:30 CEST 2010
On 22.7.2010, at 15.27, Laurent Aimar wrote:
> On Thu, Jul 22, 2010 at 03:15:47PM +0300, Juho Vähä-Herttua wrote:
>> I should note that it still gives a warning about drawable-nsobject variable not found, but that is not fatal. I left it there to keep Lunettes working.
>> @@ -220,6 +237,7 @@ void Close(vlc_object_t *this)
>> if (sys->gl.sys != NULL)
>> + vout_display_DeleteWindow(vd, sys->embed);
> If this line can be reached while sys->embed is NULL, then you should
> add a check to avoid calling vout_display_DeleteWindow.
I left it there as a sort of a replacement of the:
in the original code, even though it's called in a different location (much later). If calling vout_display_DeleteWindow should be avoided, why is it explicitly called in the current code?
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 4215 bytes
Desc: not available
More information about the vlc-devel