[vlc-devel] [PATCH] Another attempt to add vout_window_t support to macosx video output

[Laurent Aimar]

On Thu, Jul 22, 2010 at 03:33:30PM +0300, Juho Vähä-Herttua wrote:
> On 22.7.2010, at 15.27, Laurent Aimar wrote:
> > On Thu, Jul 22, 2010 at 03:15:47PM +0300, Juho Vähä-Herttua wrote:
> >> I should note that it still gives a warning about drawable-nsobject variable not found, but that is not fatal. I left it there to keep Lunettes working.
> >> 
> >> @@ -220,6 +237,7 @@ void Close(vlc_object_t *this)
> >>     if (sys->gl.sys != NULL)
> >>         vout_display_opengl_Clean(&sys->vgl);
> >> 
> >> +    vout_display_DeleteWindow(vd, sys->embed);
> > If this line can be reached while sys->embed is NULL, then you should
> > add a check to avoid calling vout_display_DeleteWindow.
> 
> I left it there as a sort of a replacement of the:
> 
> vout_display_DeleteWindow(vd, NULL);
 vout_display_DeleteWindow(vd, NULL) means that any windows kept and
unused (not yet destroyed) must be destroyed.
 It must be called in a vout_display that does not use vout_display_NewWindow()
in the Open() function but create/retreive a window by another mean. So, when
using the value from "drawable-nsobject", you should keet the call.
 Calling it in the close function is not what you want and has potential side
effects.

-- 
fenrir