[vlc-devel] [PATCH] How do we get GBA components if we superimpose all of them on R only

Sam Hocevar sam at hocevar.net
Sun Jul 25 12:45:08 CEST 2010

On Sun, Jul 25, 2010, Pankaj yadav wrote:
> And this gives all colour components to Symbian VLC..

-    *p_buffer++ = p_ybase[RED_OFFSET-((V_RED_COEF*128)>>SHIFT) + i_red] |
+    *p_buffer++ = p_ybase[RED_OFFSET-((V_RED_COEF*128)>>SHIFT) + i_red]<<24 |

   This should not be necessary. Values in p_ybase (which points to
either p_rgb16 or p_rgb32) are already shifted when the lookup table is
built (using the RGB2PIXEL macro).

   Can you please print the values in p_filter->fmt_out.video.i_rrshift,
i_lrshift etc. when using the chroma filter? My guess is that it is
these values that are wrong.


More information about the vlc-devel mailing list