[vlc-devel] Fwd: [Patch] Symbian Merge__Changes to /src/bin

[Pankaj yadav]

---------- Forwarded message ----------
From: Pankaj yadav <pankajdnapster at gmail.com>
Date: 2010/7/29
Subject: Re: [vlc-devel] [Patch] Symbian Merge__Changes to /src/bin
To: Rémi Denis-Courmont <remi at remlab.net>


Rectified

2010/7/29 Rémi Denis-Courmont <remi at remlab.net>

diff --git a/bin/vlc.c b/bin/vlc.c
> index c8a05ba..81ca99e 100644
> --- a/bin/vlc.c
> +++ b/bin/vlc.c
> @@ -44,6 +44,18 @@
>  #include <string.h>
>  #endif
>
> +#ifdef SYMBIAN
> +#include <vlc_common.h>
> +static vlc_mutex_t exit_lock = VLC_STATIC_MUTEX;
> +static vlc_cond_t  exiting = VLC_STATIC_COND;
> +void symbian_libvlc_Wait( libvlc_int_t *p_libvlc );
>
> You probably don't need that line ^^.
> You could simply mark the function as 'static'.
>
> +void symbian_libvlc_Wait( libvlc_int_t *p_libvlc )
> +{
> +    vlc_mutex_lock( &exit_lock );
> +    vlc_cond_wait( &exiting, &exit_lock );
> +    vlc_mutex_unlock( &exit_lock );
> +}
> +#endif
>
> Using a semaphore would be a lot simpler or more correct:
>        sem_wait( &exit_sem );
> here and:
>        sem_post( &exit_sem );
> in vlc_kill(). Normally, a condition variable must always have some
> external
> state, whereas a semaphore has its own internal state.
>
>
> --
> Rémi Denis-Courmont
> http://www.remlab.net/
> http://fi.linkedin.com/in/remidenis
>



-- 
Pankaj Yadav

Open Source Enthusiast



-- 
Pankaj Yadav

Open Source Enthusiast
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20100729/7ed1ad9b/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Symbian-Merge-changes-to-bin.patch
Type: text/x-patch
Size: 3800 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20100729/7ed1ad9b/attachment.bin>