[vlc-devel] [vlc-commits] commit: Qt: save volume on exit ( Francois Cartegnie )

[Rémi Denis-Courmont]

Le jeudi 29 juillet 2010 15:58:53 Francois Cartegnie, vous avez écrit :
> Le jeudi 29 juillet 2010, Laurent Aimar a écrit :
> > > +        i_volume = config_GetInt( p_intf, "qt-startvolume" );
> > > +    config_PutInt( p_intf, "volume", i_volume );
> > 
> > Unless I am wrong, you don't need to change "volume". The aout core
> > already does it. If confirmed, that part should be reverted.
> 
> No. I set the value for next instance on exit instead of setting volume on
> start. It makes vlc start at qt-startvolume value, which is a forced
> default volume, and differs from the volume var.
> 
> > > +    volconf = config_FindConfig( VLC_OBJECT(p_intf), "volume" );
> > > +    if ( volconf ) volconf->b_autosave = true;
> > 
> > Not thread safe and so not acceptable.
> > Using change_autosave() is probably the right way (in
> > src/libvlc-module.c).
> 
> Isn't that for module local vars only ?
> If you have the fix in mind, could you apply it ?
> (Last revert of the last of my set of patches totally broke the volume
> management.)

Then your patch set was totally broken.

THE CONFIGURATION MUST NOT BE SAVED UNLESS THE USER ASKS.
Full point.

And really, I do not see why Qt4 needs its own volume setting.

-- 
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis