[vlc-devel] [PATCH] Remove .txt subtitle loading

Kaarlo Räihä kaarlo.raiha at gmail.com
Sat Jul 31 20:17:31 CEST 2010

Some people have complained in forums that VLC tries to autoload .txt files
as subtitles since they have same kind of name as input file (
http://forum.videolan.org/viewtopic.php?f=14&t=55979#p244039 ). But because
those .txt files aren't subtitles, VLC will complain with dialog that says
'format of 'something.txt' cannot be detected. Have a look at the log for
details'. So I made patch that removes .txt from supported subtitle file
extension list and users will avoid the dialogs.

I haven't heard that anyone uses .txt extension for subtitle file (at least
subbers avoid it) and thus this shouldn't cause issues for regular users
(QT4 subtitle loading dialog doesn't even offer .txt extension at all).
Problem is that same check function (subtitles_Filter) is used in control.c
(line 367) and with removal of .txt those subtitles cannot be loaded
anymore. There are better ways to solve the problem (like customizable
subtitle autoload extension list for users) but I would guess this easy
solution is good enough.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20100731/4355ce22/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-remove-.txt-subtitle-autoloading-because-it-causes.patch
Type: application/octet-stream
Size: 788 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20100731/4355ce22/attachment.obj>

More information about the vlc-devel mailing list