[vlc-devel] [Patch] Allow pausing using space in playlist mode

[Hugo Beauzee-Luyssen]

2010/6/5 Rémi Denis-Courmont <remi at remlab.net>:
> Le vendredi 4 juin 2010 17:18:55 Hugo Beauzee-Luyssen, vous avez écrit :
>> When the playlist is in docked mode, it is impossible to pause the
>> playback using the 'space' key, as the QAbstractItemView catches it.
>> Though this is a standard behaviour of list, it is useless and
>> prevents the user to pause its playback using space.
>> This patch corrects it, by intercepting the key event and forwarding
>> it to the basic QWidget key handler, if the space key is pressed
>> without any modifiers, thus allowing multiple selection using space +
>> ctrl/shift.
>
> The comments say 'otherwise' in plenty of places, but there are no else
> statements. I find this suspicious.
>

Indeed, my bad.


-- 
Hugo Beauzée-Luyssen
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Playlist-Allow-pausing-the-playback-using-space.patch
Type: text/x-patch
Size: 2616 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20100605/dfd9d8c8/attachment.bin>