[vlc-devel] [Patch] Allow pausing using space in playlist mode

Rémi Denis-Courmont remi at remlab.net
Sat Jun 5 15:55:43 CEST 2010


Le samedi 5 juin 2010 16:41:59 Hugo Beauzee-Luyssen, vous avez écrit :
> 2010/6/5 Rémi Denis-Courmont <remi at remlab.net>:
> > Le vendredi 4 juin 2010 17:18:55 Hugo Beauzee-Luyssen, vous avez écrit :
> >> When the playlist is in docked mode, it is impossible to pause the
> >> playback using the 'space' key, as the QAbstractItemView catches it.
> >> Though this is a standard behaviour of list, it is useless and
> >> prevents the user to pause its playback using space.
> >> This patch corrects it, by intercepting the key event and forwarding
> >> it to the basic QWidget key handler, if the space key is pressed
> >> without any modifiers, thus allowing multiple selection using space +
> >> ctrl/shift.
> > 
> > The comments say 'otherwise' in plenty of places, but there are no else
> > statements. I find this suspicious.
> 
> Indeed, my bad.

Merged, thanks

-- 
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis



More information about the vlc-devel mailing list