[vlc-devel] Updated patch for ogg/theora seeking

[Ilkka Ollakka]

On Fri, Jun 04, 2010 at 07:11:42AM -0300, salsaman wrote:
> Hi all,
> please find attached an updated patch for ogg/theora seeking, which has been
> approved by JB.

> Please can somebody let me know when it has been applied.

Hi,

Few remarks

> +    /* gf: some frames need to be skipped after a seek */
> +    bool b_skip_frame;
> +

gf: in comments relate to you I presume? I think those could be left out
as you can use git blame to see who commited it etc?


> +    /* gf: need to skip some pages after a seek */
> +    if ( p_block->i_flags & BLOCK_FLAG_PREROLL )
> +      {
> +	p_sys->b_skip_frame = true;
> +      }

Please try to keep codingstyle consistent inside files (expanding tabs and
intend of {}).

>  /*****************************************************************************
>   * ogg.c : ogg stream demux module for vlc
>   *****************************************************************************
> - * Copyright (C) 2001-2007 the VideoLAN team
> + * Copyright (C) 2001-2010 the VideoLAN team
>   * $Id$

> --- /dev/null
> +++ b/modules/demux/oggseek.c
> @@ -0,0 +1,844 @@
> +/*****************************************************************************
> + * oggseek.c : ogg seeking functions for ogg demuxer vlc
> + *****************************************************************************
> + * Copyright (C) 2008 - 2010 Gabriel Finch <salsaman at gmail.com>
> + *
> + * Authors: Gabriel Finch <salsaman at gmail.com>

Does these codefiles originate from somewhere else that you have made in
2008?

-- 
Ilkka Ollakka
A New York City ordinance prohibits the shooting of rabbits from the
rear of a Third Avenue street car -- if the car is in motion.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20100605/a3545a06/attachment.sig>