[vlc-devel] Updated patch for ogg/theora seeking

[salsaman]

On Sat, Jun 5, 2010 at 12:13 PM, Ilkka Ollakka <ileoo at videolan.org> wrote:
> On Fri, Jun 04, 2010 at 07:11:42AM -0300, salsaman wrote:
>> Hi all,
>> please find attached an updated patch for ogg/theora seeking, which has been
>> approved by JB.
>
>> Please can somebody let me know when it has been applied.
>
> Hi,
>
> Few remarks
>
>> +    /* gf: some frames need to be skipped after a seek */
>> +    bool b_skip_frame;
>> +
>
> gf: in comments relate to you I presume? I think those could be left out
> as you can use git blame to see who commited it etc?
>

OK, I will remove the gf: and gf: end

>
>> +    /* gf: need to skip some pages after a seek */
>> +    if ( p_block->i_flags & BLOCK_FLAG_PREROLL )
>> +      {
>> +     p_sys->b_skip_frame = true;
>> +      }
>
> Please try to keep codingstyle consistent inside files (expanding tabs and
> intend of {}).
>



I am sorry but emacs does this automatically. It would be a PITA to
have to manually change everything (and probably I would miss
something or mess up closing braces), unless you know a setting for
emacs to change this. Otherwise feel free to re-indent my patches with
whatever tool you are using.




>>  /*****************************************************************************
>>   * ogg.c : ogg stream demux module for vlc
>>   *****************************************************************************
>> - * Copyright (C) 2001-2007 the VideoLAN team
>> + * Copyright (C) 2001-2010 the VideoLAN team
>>   * $Id$
>
>> --- /dev/null
>> +++ b/modules/demux/oggseek.c
>> @@ -0,0 +1,844 @@
>> +/*****************************************************************************
>> + * oggseek.c : ogg seeking functions for ogg demuxer vlc
>> + *****************************************************************************
>> + * Copyright (C) 2008 - 2010 Gabriel Finch <salsaman at gmail.com>
>> + *
>> + * Authors: Gabriel Finch <salsaman at gmail.com>
>
> Does these codefiles originate from somewhere else that you have made in
> 2008?
>

http://lives.svn.sourceforge.net/viewvc/lives/trunk/lives-plugins/plugins/decoders/ogg_theora_decoder.c


Gabriel.