[vlc-devel] [vlc-commits] commit: Qt4: reset current_index cache sametime as i_cache_id ( Ilkka Ollakka )

Ilkka Ollakka ileoo at videolan.org
Thu Jun 24 14:45:33 CEST 2010


On Wed, Jun 23, 2010 at 06:36:21PM +0200, Jakob Leben wrote:

> A QModelIndex can become invalid even in case when cached PLItem is still
> valid. For example on D&D move. QModelIndex is not permanent, so would be
> better to not cache it at all. If anything, input_item_t * should be cached.

Yep, youre right. Actually I tried to overcome data( ) const restrain as
I couldn't use currentIndex()/findById in there. But seems more and more
that this isn't the good way to implement it either.

-- 
Ilkka Ollakka
"Nice boy, but about as sharp as a sack of wet mice."
		-- Foghorn Leghorn
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20100624/509ab761/attachment.sig>


More information about the vlc-devel mailing list