[vlc-devel] [vlc-commits] commit: Qt4: reset current_index cache sametime as i_cache_id ( Ilkka Ollakka )

[Jakob Leben]

On Wed, Jun 23, 2010 at 2:10 PM, <git at videolan.org> wrote:

> vlc | branch: master | Ilkka Ollakka <ileoo at videolan.org> | Wed Jun 23
> 15:09:53 2010 +0300| [7cdb0761b23277f508cefeb5dca4098c9ec4120d] | committer:
> Ilkka Ollakka
>
> Qt4: reset current_index cache sametime as i_cache_id
>

A QModelIndex can become invalid even in case when cached PLItem is still
valid. For example on D&D move. QModelIndex is not permanent, so would be
better to not cache it at all. If anything, input_item_t * should be cached.

Caching of current item in qt4 has recently been removed in development
between 1.0.0 and 1.1.0. If you want to know last played item after playing
is stopped, then instead of caching, why not ask the playlist directly? If
playlist can stop and then continue playing from last played item, then for
sure it has the info about the last played item.

Best regards,

Jakob
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20100623/b11d6e7b/attachment.html>