[vlc-devel] [PATCH] Disable faad, lower priority of decoder below avcodec

[Rémi Denis-Courmont]

On Fri, 25 Jun 2010 21:25:03 +0200, Rafaël Carré <rafael.carre at gmail.com>
wrote:
> @@ -2833,8 +2831,8 @@ dnl
>  dnl  faad decoder plugin
>  dnl
>  AC_ARG_ENABLE(faad,
> -[  --enable-faad           faad codec (default disabled)])
> -if test "${enable_faad}" = "yes"
> +[  --disable-faad           faad codec (default disabled)])
> +if test "${enable_faad}" != "no"

The description needs to be updated too. But why should a useless plug-in
be enabled by default?

> @@ -43,7 +43,7 @@ static void Close( vlc_object_t * );
> 
>  vlc_module_begin ()
>      set_description( N_("AAC audio decoder (using libfaad2)") )
> -    set_capability( "decoder", 100 )
> +    set_capability( "decoder", 50 )

I dunno. What's the use of a codec that will always be preempted by FFmpeg?
To me, it sounds like we should remove the plugin completely instead, as
well as for libmpeg2 by the way.

-- 
Rémi Denis-Courmont
http://www.remlab.net
http://fi.linkedin.com/in/remidenis