[vlc-devel] [PATCH] Disable faad, lower priority of decoder below avcodec

[Rafaël Carré]

On Fri, 25 Jun 2010 21:29:01 +0200
Rémi Denis-Courmont <remi at remlab.net> wrote:

> 
> On Fri, 25 Jun 2010 21:25:03 +0200, Rafaël Carré
> <rafael.carre at gmail.com> wrote:
> > @@ -2833,8 +2831,8 @@ dnl
> >  dnl  faad decoder plugin
> >  dnl
> >  AC_ARG_ENABLE(faad,
> > -[  --enable-faad           faad codec (default disabled)])
> > -if test "${enable_faad}" = "yes"
> > +[  --disable-faad           faad codec (default disabled)])
> > +if test "${enable_faad}" != "no"
> 
> The description needs to be updated too. But why should a useless
> plug-in be enabled by default?

Oops, the description doesn't need to be updated, the whole
configure.ac diff must be discarded instead (i just thought faad was
enabled by default and didn't read the code)

> > @@ -43,7 +43,7 @@ static void Close( vlc_object_t * );
> > 
> >  vlc_module_begin ()
> >      set_description( N_("AAC audio decoder (using libfaad2)") )
> > -    set_capability( "decoder", 100 )
> > +    set_capability( "decoder", 50 )
> 
> I dunno. What's the use of a codec that will always be preempted by
> FFmpeg? To me, it sounds like we should remove the plugin completely
> instead, as well as for libmpeg2 by the way.

Yeah that's what i wanted to do, but I guess it doesn't harm to still
have the source around

About libmpeg2 iirc fenrir said our decoder had features that ffmpeg
decoder hasn't.

-- 
✍ Rafaël Carré ☺
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20100625/347fadde/attachment.sig>