[vlc-devel] [PATCH] Disable faad, lower priority of decoder below avcodec

Laurent Aimar fenrir at elivagar.org
Sat Jun 26 12:25:34 CEST 2010


Hi,

On Fri, 2010-06-25 at 21:25 +0200, Rafaël Carré wrote:
>  vlc_module_begin ()
>      set_description( N_("AAC audio decoder (using libfaad2)") )
> -    set_capability( "decoder", 100 )
> +    set_capability( "decoder", 50 )
>      set_category( CAT_INPUT )
>      set_subcategory( SUBCAT_INPUT_ACODEC )
>      set_callbacks( Open, Close )
 Are you sure avcodec supports every 'common' tools actually used by
AAC ? And if no, are some of them widely used ?
 Have you tested that vlc and avcodec AAC decoder do actually like each
other on a large set of files ?
 Have you tested faad vs avcodec stability against broken/corrupted
streams ?

 I am not against the change and I would prefer to have only avcodec,
but I don't want to have unneeded bug reports.

Regards,

-- 
fenrir




More information about the vlc-devel mailing list