[vlc-devel] [PATCH] Disable faad, lower priority of decoder below avcodec

[Måns Rullgård]

Laurent Aimar <fenrir at elivagar.org> writes:

> Hi,
>
> On Fri, 2010-06-25 at 21:25 +0200, Rafaël Carré wrote:
>>  vlc_module_begin ()
>>      set_description( N_("AAC audio decoder (using libfaad2)") )
>> -    set_capability( "decoder", 100 )
>> +    set_capability( "decoder", 50 )
>>      set_category( CAT_INPUT )
>>      set_subcategory( SUBCAT_INPUT_ACODEC )
>>      set_callbacks( Open, Close )
>  Are you sure avcodec supports every 'common' tools actually used by
> AAC ? And if no, are some of them widely used ?

We believe so, which is why we dropped the faad wrapper.

>  Have you tested that vlc and avcodec AAC decoder do actually like each
> other on a large set of files ?

I'd suggest paying extra attention to channel order on multi-channel
files.  There might be differences there.

>  Have you tested faad vs avcodec stability against broken/corrupted
> streams ?

We believe the avcodec aac decoder to be resilient, but more testing
is always welcome.

-- 
Måns Rullgård
mans at mansr.com