[vlc-devel] [PATCH] Disable faad, lower priority of decoder below avcodec
rafael.carre at gmail.com
Sat Jun 26 18:13:02 CEST 2010
On Sat, 26 Jun 2010 12:25:34 +0200
Laurent Aimar <fenrir at elivagar.org> wrote:
> On Fri, 2010-06-25 at 21:25 +0200, Rafaël Carré wrote:
> > vlc_module_begin ()
> > set_description( N_("AAC audio decoder (using libfaad2)") )
> > - set_capability( "decoder", 100 )
> > + set_capability( "decoder", 50 )
> > set_category( CAT_INPUT )
> > set_subcategory( SUBCAT_INPUT_ACODEC )
> > set_callbacks( Open, Close )
> Are you sure avcodec supports every 'common' tools actually used by
> AAC ? And if no, are some of them widely used ?
Like Måns said the avcodec decoder should be complete
> Have you tested that vlc and avcodec AAC decoder do actually like
> each other on a large set of files ?
No but if you have a collection of samples somewhere i can do that and
> Have you tested faad vs avcodec stability against broken/corrupted
> streams ?
Running zzuf against an aac-lc produced by faac looks fine
> I am not against the change and I would prefer to have only avcodec,
> but I don't want to have unneeded bug reports.
If there are problems we can forward bug reports to ffmpeg ;)
IMO if we lower faad priority now that 1.1 was just released that will
give us more time to see if there are regressions.
✍ Rafaël Carré ☺
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 198 bytes
Desc: not available
More information about the vlc-devel