[vlc-devel] [PATCH] Qt: active/passive actions Views menu coherency

Jean-Baptiste Kempf jb at videolan.org
Sun Mar 7 20:04:05 CET 2010


On Sun, Mar 07, 2010 at 07:54:41PM +0100, Francois Cartegnie wrote :
> -            qtr( "Play&list" ), mi,
> +            qtr( "Show Play&list" ), mi,
No, it isn't show. It is show/hide.

> -    action = menu->addAction( qtr( "Mi&nimal View" ) );
> +    action = menu->addAction( qtr( "Switch to Mi&nimal Interface" ) );
It isn't Switch to, since it can be also switch from

>      /* FullScreen View */
> -    action = menu->addAction( qtr( "&Fullscreen Interface" ), mi,
> +    action = menu->addAction( qtr( "Switch to &Fullscreen Interface" ), mi,
idem.

> -    action = menu->addAction( qtr( "&Advanced Controls" ), mi,
> +    action = menu->addAction( qtr( "Show &Advanced Controls" ), mi,
No, it isn't show. It is show/hide.

>      /* Docked Playlist */
> -    action = menu->addAction( qtr( "Docked Playlist" ) );
> +    action = menu->addAction( qtr( "Dock Playlist" ) );
No, it isn't dock, it is dock/undock. Docked is a state and is
checkable.

>  #if 0 /* For Visualisations. Not yet working */
> -    adv = menu->addAction( qtr( "Visualizations selector" ),
> +    adv = menu->addAction( qtr( "Select Visualizers" ),
  ok.


-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/



More information about the vlc-devel mailing list