[vlc-devel] [PATCH] VLM : move a mutex lock/unlock + deadlock question

[Sébastien Escudier]

Hi,

Correct me if I am wrong, but I think we could save some useless lock/unlock
calls in VLM manage thread. See attached patch.

By the way, I found a possible deadlock since recent changes in this thread.
If a media is deleted with a call to vlm_Control, then here is what is happening
:


lock p_vlm->lock
vlm_ControlMediaDel
vlm_ControlMediaInstanceStop
vlm_MediaInstanceDelete
var_DelCallback
[...]

But if the input triggered a callback between the lock and var_DelCallback, then
input thread is blocked in the callback while var_DelCallback is blocked in
var_DelCallback -> WaitUnused

Any idea ?

Regards,

Seb
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-VLM-move-a-mutex-lock-unlock.patch
Type: text/x-patch
Size: 1123 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20100318/677e0a30/attachment.bin>