[vlc-devel] [vlc-commits] commit: Qt: make ground for proper main interface size management ( Jakob Leben )

[Jean-Baptiste Kempf]

On Sat, Mar 27, 2010 at 11:51:37PM +0100, git at videolan.org wrote :
> vlc | branch: master | Jakob Leben <jleben at videolan.org> | Sat Mar 27 22:24:50 2010 +0100| [9d9ffe9fba7946afcf6f20f1de9f6b6a3b644f37] | committer: Jakob Leben 
> 
> Qt: make ground for proper main interface size management

I object this commit.

minWidthHolder is a hack.
your videoRoleWidget is a hack too, it doesn't simplify anything, as you
can see with showTab() function that needs now a switch! (and force a
resize to 0,0 in certain cases...

you call showTab() everywhere, that is an inline function with a switch!
you don't fix the issues that are still present, namely adaptGeometry()
and mainBasedVideoSize

And finally, this breaks when you do simple things like
bgWidget->resize->playlist->playlist, because you don't see the bgWidget
anymore, which makes it totally useless to see art when playing music.

Moreover, I told you that this wasn't ok to commit.

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/