[vlc-devel] [PATCH] Use Mach semaphores on Mac OS X
remi at remlab.net
Fri May 7 16:10:38 CEST 2010
Le jeudi 6 mai 2010 17:59:40 Juho Vähä-Herttua, vous avez écrit :
> On 6.5.2010, at 16.15, Juho Vähä-Herttua wrote:
> > There's one problem with the patch. It calls for VLC_THREAD_ASSERT that
> > calls vlc_thread_fatal on debug, which in turn calls strerror_r, which
> > fails because the return value is not errno value but instead
> > kern_return_t. ILEoo also mentioned that after semaphore_destroy the
> > condition should be val == KERN_SUCCESS instead of != check.
> Last patch was complete crap: in addition to the above, semaphore_destroy
> didn't reference the pointer, error code path of vlc_sem_post didn't
> return a value correctly on non-Mac platform. Second attempt included, I
> used EINVAL for all error cases since it was easy and VLC_THREAD_ASSERT is
> already there.
Merged. Please check git whit space warnings next time.
More information about the vlc-devel