[vlc-devel] [PATCH 1/2] Fnordlicht support added. Fnordlicht-Class is based on the MoMo-Class. The Fnordlicht-Class implements oly parts of the fnordlicht-protocol: sync, stop and fade_rgb Have a look at http://github.com/fd0/fnordlicht/raw/master/doc/PROTOCOL for more details.

[Jean-Baptiste Kempf]

On Thu, May 13, 2010 at 07:43:51PM +0200, Kai Lauterbach wrote :
> -      actMoMoLight  = 6
> +      actMoMoLight  = 6,
> +      actFnordlicht  = 7
alignment?

> +++ b/modules/video_filter/atmo/FnordlichtConnection.cpp
Missing licence on all new files.

General remarks:
you should probably use snprintf a bit more.
you should send msg_Err when you have issues and not returning without
explanations
Why are you using DWORD?

Has the code been tested on linux or just on Windows?

Best Regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/