[vlc-devel] [PATCH 1/2] Fnordlicht support added. Fnordlicht-Class is based on the MoMo-Class. The Fnordlicht-Class implements oly parts of the fnordlicht-protocol: sync, stop and fade_rgb Have a look at http://github.com/fd0/fnordlicht/raw/master/doc/PROTOCOL for more details.

[Kai Lauterbach]

Am Freitag, den 14.05.2010, 00:15 +0200 schrieb Jean-Baptiste Kempf:
> On Thu, May 13, 2010 at 07:43:51PM +0200, Kai Lauterbach wrote :
> > -      actMoMoLight  = 6
> > +      actMoMoLight  = 6,
> > +      actFnordlicht  = 7
> alignment?

What do you mean with alignment? I've removed the "excessive" space
character...

> > +++ b/modules/video_filter/atmo/FnordlichtConnection.cpp
> Missing licence on all new files.

Done...

> General remarks:
> you should probably use snprintf a bit more.
> you should send msg_Err when you have issues and not returning without
> explanations
> Why are you using DWORD?

Because I just made a copy of the MoMoConnection class-files and just
made changes to get it work with the fnordlicht device.
I'll see what I can do next week.

> Has the code been tested on linux or just on Windows?

The code has been tested on linux only. There is a short video where you
can see how the colors change (in daylight so the LED's are very
darkish) on http://klautesblog.blogspot.com

Best regards


-- 
Kai Lauterbach - lauterbach.kai at web.de
Blog: http://klautesblog.blogspot.com

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Missing-licence-added-to-FnordlichtConnection-Files.patch
Type: text/x-patch
Size: 3427 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20100514/b4c928f8/attachment.bin>