[vlc-devel] [PATCH 1/2] Fnordlicht support added. Fnordlicht-Class is based on the MoMo-Class. The Fnordlicht-Class implements oly parts of the fnordlicht-protocol: sync, stop and fade_rgb Have a look at http://github.com/fd0/fnordlicht/raw/master/doc/PROTOCOL for more details.

[Jean-Baptiste Kempf]

On Fri, May 14, 2010 at 01:24:02AM +0200, Kai Lauterbach wrote :
> Am Freitag, den 14.05.2010, 00:15 +0200 schrieb Jean-Baptiste Kempf:
> > On Thu, May 13, 2010 at 07:43:51PM +0200, Kai Lauterbach wrote :
> > > -      actMoMoLight  = 6
> > > +      actMoMoLight  = 6,
> > > +      actFnordlicht  = 7
> > alignment?
> 
> What do you mean with alignment? I've removed the "excessive" space
> character...
yep.

> > General remarks:
> > you should probably use snprintf a bit more.
> > you should send msg_Err when you have issues and not returning without
> > explanations
> > Why are you using DWORD?
> 
> Because I just made a copy of the MoMoConnection class-files and just
> made changes to get it work with the fnordlicht device.
> I'll see what I can do next week.
Ok. If the rest of the code does it, it is kind of OK, but I would
prefer non-Windows types.

> > Has the code been tested on linux or just on Windows?
> The code has been tested on linux only. There is a short video where you
> can see how the colors change (in daylight so the LED's are very
> darkish) on http://klautesblog.blogspot.com
Nice.

Btw, could you squash the 2 commits? (git rebase -i )

Best Regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/